Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed docker setup #4166

Closed
wants to merge 2 commits into from
Closed

Removed docker setup #4166

wants to merge 2 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 24, 2024

Dow we really need it? Isnt it better to simply use DDEV, that seems to be more flexible - and maintain the docker repo instead? Do we need it here in the main repo?

@sreichel sreichel marked this pull request as draft September 16, 2024 23:31
@colinmollenhour
Copy link
Member

I don't think it should be removed. Reasons:

  • Not everyone uses ddev - it is the most robust option but I don't think it is ubiquitous enough to make it basically required.
  • It provides a good blueprint for a production deployment, ddev doesn't do this at all
  • If we are going to run things like GitPod, Codespaces, Devcontainer, Cypress, etc. we need a basic working container anyway, I don't think ddev is suitable for those
  • It could be moved to a separate repo, but having a single command that launches a full environment in the repo itself is I think a valuable feature - for example if a person wants to make or try out a tiny patch without affecting their main environment and not set up ddev they can do it in seconds with this.

It's currently using images from https://github.com/colinmollenhour/docker-openmage/ but I would be fine consolidating these two somehow. When tinkering with FrankenPHP I learned of https://github.com/mlocati/docker-php-extension-installer which can greatly simplify maintaining custom PHP docker images so it really isn't that hard.

@sreichel sreichel closed this Sep 17, 2024
@sreichel sreichel deleted the no-docker branch September 18, 2024 02:21
@sreichel
Copy link
Contributor Author

sreichel commented Sep 22, 2024

  • It provides a good blueprint for a production deployment, ddev doesn't do this at all

Yep. DDEV is for local development only, not for production.

  • If we are going to run things like GitPod, Codespaces, Devcontainer, Cypress, etc. we need a basic working container anyway, I don't think ddev is suitable for those

You're right. For Gibtpod and some others we need the docker container, but for Cypress ... https://github.com/tyler36/ddev-cypress

@colinmollenhour
Copy link
Member

You're right. For Gibtpod and some others we need the docker container, but for Cypress ... https://github.com/tyler36/ddev-cypress

Very nice. I was going to say if we use Cypress we will also want to run it in Github Actions which I think ddev is not well-suited.. but then I Googled and would have been proven wrong. :D https://github.com/ddev/github-action-setup-ddev

@sreichel
Copy link
Contributor Author

From google translate ... DDEV is a "Egg-laying jack of all trades" for development ;)

#945 (comment) ? Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants