Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.x] Deprecated functionality: strtotime(): Passing null to para… #4339

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

addison74
Copy link
Contributor

…meter # 1 ($datetime).

This PR fixes #4338.

@github-actions github-actions bot added the Component: CatalogRule Relates to Mage_CatalogRule label Nov 7, 2024
@addison74 addison74 changed the title PHP 8.x] Deprecated functionality: strtotime(): Passing null to para… [PHP 8.x] Deprecated functionality: strtotime(): Passing null to para… Nov 7, 2024
@sreichel
Copy link
Contributor

sreichel commented Nov 7, 2024

Can you please update a docblock for Mage_Rule_Model_Resource_Abstract::_beforeSave()?

Please add @param Mage_CatalogRule_Model_Rule $object $object.

Not required for this PR, but some help for IDE.

@addison74
Copy link
Contributor Author

@sreichel - Will you add in other PR the docblock you mentioned before?

@kiatng kiatng merged commit 68cfcd9 into OpenMage:main Nov 10, 2024
18 checks passed
fballiano added a commit to MahoCommerce/maho that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogRule Relates to Mage_CatalogRule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP 8.x] Deprecated functionality: strtotime(): Passing null to parameter #1 ($datetime)
3 participants