PHPUnit: added tests #4340
Merged
PHPUnit: added tests #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addison74
previously approved these changes
Nov 7, 2024
github-actions
bot
added
the
Component: AdminNotification
kiatng
previously approved these changes
Nov 11, 2024
addison74
previously approved these changes
Nov 11, 2024
|
@sreichel - Please do not merge this PR, it needs a few fixes. |
|
Started with ~40 tests, now we have +500. Codecoverage is not worth to mention - its still below 10% - and it may take some PRs to make visible progress, but i already found some code issues/bugs. |
# Conflicts: # app/code/core/Mage/AdminNotification/Model/Feed.php
github-actions
bot
removed
the
Component: AdminNotification
addison74
approved these changes
Nov 22, 2024
kiatng
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
More unit tests.