Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: create empty SimpleXMLElement #4351

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Fix: create empty SimpleXMLElement #4351

merged 1 commit into from
Nov 16, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 12, 2024 •
edited
Loading

Description (*)

This causes a fatal error, because its no valid xml (no root element)

new SimpleXMLElement('<?xml version="1.0" encoding="utf-8" ?>');

@github-actions github-actions bot added the Component: AdminNotification Relates to Mage_AdminNotification label Nov 12, 2024
@addison74 addison74 merged commit 25a2e9f into OpenMage:main Nov 16, 2024
19 checks passed
@sreichel sreichel deleted the simplexml branch November 17, 2024 02:28
fballiano added a commit to MahoCommerce/maho that referenced this pull request Nov 17, 2024
@fballiano
OM PR 4351
171fb54 
OpenMage/magento-lts#4351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: AdminNotification Relates to Mage_AdminNotification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @addison74