Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Possible Array Access warnings in Captcha Observer #4424

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Dec 18, 2024

Description (*)

This Fixes Possible PHP Warnings when there is a POST Param is missing, like:

  • Undefined array key $formId
  • Trying to access array offset on null

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Possible Array Access warnings in Captcha Observer #4414

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Captcha Relates to Mage_Captcha label Dec 18, 2024
@sreichel sreichel merged commit c9a901f into OpenMage:main Dec 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Captcha Relates to Mage_Captcha
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Array Access warnings in Captcha Observer
3 participants