Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpUnit: fixes Update LayoutTest.php #4453

Merged
merged 12 commits into from
Jan 11, 2025
Merged

PhpUnit: fixes Update LayoutTest.php #4453

merged 12 commits into from
Jan 11, 2025

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 6, 2025

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

Test Results

539 tests   531 ✅  2s ⏱️
145 suites    8 💤
  1 files      0 ❌

Results for commit 660c461.

♻️ This comment has been updated with latest results.

@sreichel sreichel added this to the 20.12.0 milestone Jan 6, 2025
@sreichel sreichel added the chore label Jan 6, 2025
@sreichel
Copy link
Contributor Author

sreichel commented Jan 7, 2025

Skip one test. Seems to be a bug in phpunit v9. (?)

@Hanmac
Copy link
Contributor

Hanmac commented Jan 8, 2025

@sreichel your problem is a change in PHP core:
https://3v4l.org/XGAS6

PHP8:

Fatal error: Uncaught Error: Class "WrongClassName" not found in /in/XGAS6:3

PHP7

Fatal error: Uncaught Error: Class 'WrongClassName' not found in /in/XGAS6:3

@sreichel
Copy link
Contributor Author

sreichel commented Jan 8, 2025

There is also related ticket at phpunit for quotes in error messages. JJust skip that test atm.

@Hanmac
Copy link
Contributor

Hanmac commented Jan 8, 2025

I mean, it isn't really something that is affected by phpunit?
Wouldn't it be much easier to just check PHP_VERSION_ID for now?

@sreichel
Copy link
Contributor Author

sreichel commented Jan 8, 2025

Thanks. Updated test.

sreichel added a commit to sreichel/magento-lts that referenced this pull request Jan 8, 2025
@sreichel
updated test, ref OpenMage#4453
cb2b0f6
@sreichel
Copy link
Contributor Author

sreichel commented Jan 9, 2025

@kiatng please check. That blocks some other PRs.

@Hanmac Hanmac merged commit 2a4ebc4 into main Jan 11, 2025
32 checks passed
@sreichel sreichel deleted the sreichel-patch-1 branch January 11, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@Hanmac Hanmac Hanmac approved these changes

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

@kiatng kiatng Awaiting requested review from kiatng

Assignees
No one assigned
Labels
chore phpunit
Projects
None yet
Milestone
20.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @Hanmac @addison74