Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.4 build failure in osx #1902

Closed
isuruf opened this issue Dec 3, 2018 · 6 comments
Closed

v0.3.4 build failure in osx #1902

isuruf opened this issue Dec 3, 2018 · 6 comments
Milestone

Comments

@isuruf
Copy link
Contributor

isuruf commented Dec 3, 2018

Building for DYNAMIC_ARCH fails with,

../kernel/x86_64/dgemm_kernel_4x8_skylakex.c:872:5: error: invalid alignment value
                        ".align 32\n"
                         ^
<inline asm>:26:8: note: instantiated into assembly here
.align 32
       ^
../kernel/x86_64/dgemm_kernel_4x8_skylakex.c:1040:5: error: invalid alignment value
                        ".align 32\n"
                         ^
<inline asm>:18:8: note: instantiated into assembly here
.align 32
       ^
../kernel/x86_64/dgemm_kernel_4x8_skylakex.c:1168:5: error: invalid alignment value
                        ".align 32\n"
                         ^
<inline asm>:11:8: note: instantiated into assembly here
.align 32

Let me know if you need more info on the build environment.

@martin-frbg
Copy link
Collaborator

Looks like a return of the OSX ".align vs .p2align" issue of #1470 (i.e. these should probably be converted to ".p2align 5")

@matthew-brett
Copy link
Contributor

@brada4
Copy link
Contributor

brada4 commented Dec 3, 2018

You can quickly avoid building the implicated code by setting NO_AVX512=1 and mapping skylakex to haswell.

@martin-frbg
Copy link
Collaborator

We (Numpy) just hit this too:

Yeah that is the beauty of this project - any small oversight at release time is going to hit a lot of projects. Fix in place now.

@martin-frbg martin-frbg added this to the 0.3.5 milestone Dec 3, 2018
matthew-brett added a commit to MacPython/openblas-libs that referenced this issue Dec 3, 2018
@matthew-brett
Copy link
Contributor

Thanks for fixing so quickly.

@isuruf
Copy link
Contributor Author

isuruf commented Dec 6, 2018

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants