Build wheels for Python 3.13 and drop support for 3.8 #1858
+35
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinarakaki
force-pushed
the
python-3.13
branch
from
e740adc to
d43598f
Compare
.github/workflows/ci.yml
Outdated
| os: [ubuntu-20.04] | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
Can you set to ubuntu-22.04 here? latest version will change over time, it is better to set a specified version
docs/requirements.txt
Outdated
| sphinx==4.5.* | ||
| sphinx<6 |
There was a problem hiding this comment.
To fix the pipeline error, I think you could set sphinx==5.3.. The pipeline always takes version 4.5. at this time.
|
Thank you for your PR, please update the PR and I will merge soon. |
rinarakaki
force-pushed
the
python-3.13
branch
3 times, most recently
from
9464a13 to
636dc85
Compare
|
I'm figuring out that we need to cut the OpenNMT/TensorFlow/PyTorch related test code here.. |
rinarakaki
force-pushed
the
python-3.13
branch
from
636dc85 to
76fb3b5
Compare
rinarakaki
force-pushed
the
python-3.13
branch
from
76fb3b5 to
73b5070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1853, #1857.
@minhthuc2502
Could you please review this PR?