Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore role should use normpath instead of realpath #60

Closed
3 tasks
sk4zuzu opened this issue Jun 14, 2024 · 0 comments
Closed
3 tasks

Datastore role should use normpath instead of realpath #60

sk4zuzu opened this issue Jun 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sk4zuzu
Copy link
Contributor

sk4zuzu commented Jun 14, 2024

Description
From ansible docs: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis

Filters always run on the controller so this path is resolved using the controller’s filesystem.

Datastore role incorrectly uses the realpath filter which may yield unpredictable results, it should be replaced with normpath filter or be removed altogether.

To Reproduce
N/A

Expected behavior
N/A

Details

  • Ansible version: N/A
  • Linux OS distro in your cluster: N/A
  • Version: master

Additional context
N/A

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
@sk4zuzu sk4zuzu added the bug Something isn't working label Jun 14, 2024
@sk4zuzu sk4zuzu self-assigned this Jun 14, 2024
@sk4zuzu sk4zuzu changed the title Datastore role should use normpath instead of realpah Datastore role should use normpath instead of realpath Jun 14, 2024
rsmontero pushed a commit that referenced this issue Jun 18, 2024
Use a normalized path ('/var/lib/one') for the datastore path, and not  '/var//lib/one'
@sk4zuzu sk4zuzu closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant