Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues ds005613: different size on two identical versions after problem with validation, journal waiting for final version since Nov. 20 #3250

Closed
alessandra-rampinini opened this issue Dec 4, 2024 · 3 comments
Labels

Comments

@alessandra-rampinini
Copy link

alessandra-rampinini commented Dec 4, 2024

What went wrong?

ds005613

Warning: posted previously, issue partially solved.
What is solved: validation now completed and not pending anymore.
What is not solved:

  • dataset is incomplete in v.1.0.2 while no files were deleted, 20Gb missing.
  • dataset looks invalid while actually valid.

Detailed account:

Hi! The dataset for v1.0.2 at https://openneuro.org/datasets/ds005613/versions/1.0.2 has multiple issues upon just updating the readme file.
Validation
it shows a huge difference in size while I only updated the readme
v1.0.2
imagev1.0.1
v.1.0.1 (correct size)
image

it looks invalid from my dataset list:
image
but it is valid

I only corrected a typo in the readme for the publication between v.1.0.1 and v.1.0.2, so I'm wondering what is happening.
The journal has been told to review v.1.0.1 but they want a definitive version and are now waiting to send my paper to production, it's been more than 2 weeks and I really need urgent help.
I'd be grateful if someone

  1. deleted v.1.0.2 at this point maybe it's easier
  2. could give me an idea of what is happening

best,
alessandra

Expected behavior

Dataset v .1.0.2 should have same file number and size as v 1.0.1 and should look valid from my dataset list.

How to reproduce

  1. go to https://openneuro.org/datasets/ds005613
  2. select versions 1.0.1 and 1.0.2 from right hand side menu 'versions' and see difference in size.

Desktop

  • OS: mac os
  • Browser: chrome

Phone

No response

Additional information

There are also A LOT of warnings not present before that are redundant.

@alessandra-rampinini alessandra-rampinini changed the title Multiple issues ds: different size on two identical versions, validation pending forever, journal waiting for final version since Nov. 20 Multiple issues ds005613: different size on two identical versions, validation pending forever, journal waiting for final version since Nov. 20 Dec 4, 2024
@alessandra-rampinini alessandra-rampinini changed the title Multiple issues ds005613: different size on two identical versions, validation pending forever, journal waiting for final version since Nov. 20 Multiple issues ds005613: different size on two identical versions after problem with validation, journal waiting for final version since Nov. 20 Dec 4, 2024
@nellh
Copy link
Contributor

nellh commented Dec 4, 2024

The difference here is that 1.0.1 was validated with the legacy BIDS validator and 1.0.2 was validated with the new 2.0 validator. You can read an announcement about this here. Generally the 2.0 version will catch more issues than the legacy BIDS validator, so more warnings or new errors is expected.

The new validator is detecting errors in your dataset. There is a bug with how this is being displayed on the OpenNeuro side. I can remove the 1.0.2 snapshot for now if you'd prefer to have the 1.0.1 version become the canonical version for now. Future versions will need to pass the 2.0 BIDS validator as that is the only one supported on OpenNeuro after the 4.29.0 release.

@alessandra-rampinini
Copy link
Author

The difference here is that 1.0.1 was validated with the legacy BIDS validator and 1.0.2 was validated with the new 2.0 validator. You can read an announcement about this here. Generally the 2.0 version will catch more issues than the legacy BIDS validator, so more warnings or new errors is expected.

The new validator is detecting errors in your dataset. There is a bug with how this is being displayed on the OpenNeuro side. I can remove the 1.0.2 snapshot for now if you'd prefer to have the 1.0.1 version become the canonical version for now. Future versions will need to pass the 2.0 BIDS validator as that is the only one supported on OpenNeuro after the 4.29.0 release.

Thank you for this explanation, it's clear now what's happening. And how about the difference in size between the two versions? Any reason you might think of?
As a concrete answer to your proposal: yes please, delete the v1.0.2 snapshot for me, I'll keep the 1.0.1 as the canonical one and work on any future versions with the new validator, but no need to have this 1.0.2 now as the journal expects 1.0.1 to be the one referenced in the data descriptor. thank you so much!

@nellh
Copy link
Contributor

nellh commented Dec 10, 2024

The 1.0.2 snapshot was marked deprecated and removed.

@nellh nellh closed this as completed Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants