Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Validation should pass full issues list to display component for errors and warnings #3251

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Dec 4, 2024

Fixes an issue that would hide errors in datasets with the 2.0 validator.

See #3250

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.68%. Comparing base (e18cf44) to head (43ac21a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...penneuro-app/src/scripts/validation/validation.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3251   +/-   ##
=======================================
  Coverage   45.68%   45.68%           
=======================================
  Files         595      595           
  Lines       38014    38014           
  Branches     1171     1171           
=======================================
  Hits        17366    17366           
  Misses      20451    20451           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 187ba58 into master Dec 4, 2024
13 of 15 checks passed
@nellh nellh deleted the fix-validation-error-display branch December 4, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant