Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Disable ReadMore component for FileTree #2633

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jul 18, 2022

Fixes issues with the FileTree component getting truncated by the ReadMore wrapper component. This will always show the full file listing now and tooltips are no longer cut off.

I gave scrolling within the file tree a try but this complicated navigation (especially on small screens) more than I think it helps with the few datasets that have a very large top level listings. Since we collapse directories anyways, it's rare enough to have a huge top level page that I think we should just leave the top level visible.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #2633 (58a0872) into master (6f58fd8) will decrease coverage by 0.01%.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##           master    #2633      +/-   ##
==========================================
- Coverage   32.18%   32.16%   -0.02%     
==========================================
  Files         589      589              
  Lines       35673    35647      -26     
  Branches      903      902       -1     
==========================================
- Hits        11481    11467      -14     
+ Misses      24062    24050      -12     
  Partials      130      130              
Impacted Files Coverage Δ
...app/src/scripts/dataset/routes/dataset-default.tsx 0.00% <0.00%> (ø)
...pp/src/scripts/dataset/routes/snapshot-default.tsx 0.00% <0.00%> (ø)
...es/openneuro-components/src/read-more/ReadMore.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@nellh nellh merged commit 4c1266e into master Jul 25, 2022
@nellh nellh deleted the readmore-fix branch July 25, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant