Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update to React Router v6 and React 18 #2661

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Sep 7, 2022

All the required updates to move to the latest release of React Router, unlocking some blocked upgrades for other dependencies (including React 18).

Fixes #2657 and #2656

@nellh
Copy link
Contributor Author

nellh commented Sep 7, 2022

Looks like tests hang in CI, working on it.

@nellh
Copy link
Contributor Author

nellh commented Sep 7, 2022

Looks like tests hang in CI, working on it.

Fixed these now.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #2661 (d1bbcfc) into master (bb9e722) will increase coverage by 0.29%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
+ Coverage   39.37%   39.67%   +0.29%     
==========================================
  Files         562      562              
  Lines       34408    34268     -140     
  Branches      903      910       +7     
==========================================
+ Hits        13549    13595      +46     
+ Misses      20734    20548     -186     
  Partials      125      125              
Impacted Files Coverage Δ
packages/openneuro-app/src/client.jsx 0.00% <0.00%> (ø)
...neuro-app/src/scripts/common/containers/header.tsx 0.00% <0.00%> (ø)
...euro-app/src/scripts/datalad/mutations/publish.jsx 0.00% <0.00%> (ø)
...uro-app/src/scripts/datalad/mutations/snapshot.tsx 0.00% <0.00%> (ø)
...pp/src/scripts/datalad/routes/dataset-redirect.tsx 0.00% <0.00%> (ø)
...penneuro-app/src/scripts/dataset/dataset-query.jsx 0.00% <0.00%> (ø)
...enneuro-app/src/scripts/dataset/dataset-routes.jsx 0.00% <0.00%> (ø)
...nneuro-app/src/scripts/dataset/draft-container.tsx 0.00% <0.00%> (ø)
...-app/src/scripts/dataset/draft-snapshot-routes.tsx 0.00% <0.00%> (ø)
...euro-app/src/scripts/dataset/mutations/publish.jsx 0.00% <0.00%> (-49.16%) ⬇️
... and 32 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nellh nellh merged commit d8dd6e7 into master Sep 7, 2022
@nellh nellh deleted the react-router-v6 branch September 7, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to react-router v6
2 participants