fix(app): Prevent a crash when modality is undefined instead of null/string #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nellh
force-pushed
the
2680-undefined-modality-crash-fix
branch
from
0a5a32b to
18f7fb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2681 +/- ##
==========================================
+ Coverage 39.65% 39.78% +0.12%
==========================================
Files 561 561
Lines 34281 34281
Branches 910 912 +2
==========================================
+ Hits 13594 13637 +43
+ Misses 20562 20519 -43
Partials 125 125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test and fixes #2680