Fix bug preventing modality cube links from working #2688
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2688 +/- ##
==========================================
+ Coverage 39.88% 39.91% +0.03%
==========================================
Files 562 563 +1
Lines 34357 34377 +20
Branches 912 914 +2
==========================================
+ Hits 13702 13722 +20
Misses 20529 20529
Partials 126 126
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Confirmed it worked locally.
Not an issue but if you click a modality cube and then go back you end up with the chunky search params from the current initialization in the URL. Not noticing this behavior any where else at the moment.
http://localhost/?query=%7B%22keywords%22%3A%5B%5D%2C%22searchAllDatasets%22%3Afalse%2C%22datasetType_available%22%3A%5B%7B%22label%22%3A%22All+Public%22%2C%22value%22%3A%22All+Public%22%7D%2C%7B%22label%22%3A%22Following%22%2C%22value%22%3A%22Following%22%7D%2C%7B%22label%22%3A%22My+Datasets%22%2C%22value%22%3A%22My+Datasets%22%7D%2C%7B%22label%22%3A%22My+Bookmarks%22%2C%22value%22%3A%22My+Bookmarks%22%7D%5D%2C%22datasetType_selected%22%3A%22All+Public%22%2C%22datasetStatus_available%22%3A%5B%7B%22label%22%3A%22Public%22%2C%22value%22%3A%22Public%22%7D%2C%7B%22label%22%3A%22Shared+with+Me%22%2C%22value%22%3A%22Shared+with+Me%22%7D%2C%7B%22label%22%3A%22Invalid%22%2C%22value%22%3A%22Invalid%22%7D%5D%2C%22datasetStatus_selected%22%3Anull%2C%22modality_available%22%3A%5B%7B%22label%22%3A%22MRI%22%2C%22value%22%3A%22MRI%22%2C%22portalPath%22%3A%22%2Fsearch%2Fmodality%2Fmri%22%2C%22count%22%3Anull%7D%2C%7B%22label%22%3A%22PET%22%2C%22value%22%3A%22PET%22%2C%22portalPath%22%3A%22%2Fsearch%2Fmodality%2Fpet%22%2C%22count%22%3Anull%7D%2C%7B%22label%22%3A%22EEG%22%2C%22value%22%3A%22EEG%22%2C%22portalPath%22%3A%22%2Fsearch%2Fmodality%2Feeg%22%2C%22count%22%3Anull%7D%2C%7B%22label%22%3A%22iEEG%22%2C%22value%22%3A%22iEEG%22%2C%22portalPath%22%3A%22%2Fsearch%2Fmodality%2Fieeg%22%2C%22count%22%3Anull%7D%2C%7B%22label%22%3A%22MEG%22%2C%22value%22%3A%22MEG%22%2C%22portalPath%22%3A%22%2Fsearch%2Fmodality%2Fmeg%22%2C%22count%22%3Anull%7D%5D%2C%22modality_selected%22%3Anull%2C%22ageRange%22%3A%5Bnull%2Cnull%5D%2C%22subjectCountRange%22%3A%5Bnull%2Cnull%5D%2C%22diagnosis_available%22%3A%5B%22Healthy+%2F+Control%22%2C%22Schizophrenia%22%2C%22ADD%2FADHD%22%2C%22Alzheimers%22%2C%22Other%22%5D%2C%22diagnosis_selected%22%3Anull%2C%22tasks%22%3A%5B%5D%2C%22authors%22%3A%5B%5D%2C%22sex_available%22%3A%5B%22All%22%2C%22Male%22%2C%22Female%22%5D%2C%22sex_selected%22%3A%22All%22%2C%22date_available%22%3A%5B%22All+Time%22%2C%22Last+30+days%22%2C%22Last+180+days%22%2C%22Last+12+months%22%5D%2C%22date_selected%22%3A%22All+Time%22%2C%22species_available%22%3A%5B%22Human%22%2C%22Rat%22%2C%22Mouse%22%2C%22Other%22%5D%2C%22species_selected%22%3Anull%2C%22section_available%22%3A%5B%22Cross-Sectional%22%2C%22Longitudinal%22%2C%22Other%22%5D%2C%22section_selected%22%3Anull%2C%22studyDomains%22%3A%5B%5D%2C%22bodyParts%22%3A%5B%5D%2C%22scannerManufacturers%22%3A%5B%5D%2C%22scannerManufacturersModelNames%22%3A%5B%5D%2C%22tracerNames%22%3A%5B%5D%2C%22tracerRadionuclides%22%3A%5B%5D%2C%22sortBy_available%22%3A%5B%7B%22label%22%3A%22Relevance%22%2C%22value%22%3A%22relevance%22%7D%2C%7B%22label%22%3A%22Newest%22%2C%22value%22%3A%22newest%22%7D%2C%7B%22label%22%3A%22Oldest%22%2C%22value%22%3A%22oldest%22%7D%2C%7B%22label%22%3A%22Activity%22%2C%22value%22%3A%22activity%22%7D%5D%2C%22sortBy_selected%22%3A%7B%22label%22%3A%22Relevance%22%2C%22value%22%3A%22relevance%22%7D%7D
The setState callback that is mimicked by SearchParamsProvider in #2684 also needs to support the object case. Adds a test for this behavior.