Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Set snapshotTag value for FileDisplay on snapshots #2723

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Nov 29, 2022

Fixes an issue where the FileDisplay component would not use the snapshot version in the URL for loading a file.

Previously the 1.0.1 snapshot would try to load a file like this:
https://openneuro.org/crn/datasets/ds001033/files/sub-02:anat:sub-02_T1w.nii.gz

Correct URL looks like this:
https://openneuro.org/crn/datasets/ds001033/snapshots/1.0.1/files/sub-02:anat:sub-02_T1w.nii.gz

This is a regression caused by the React Router V6 updates.

@nellh nellh requested a review from rwblair November 29, 2022 16:13
@nellh nellh marked this pull request as ready for review November 29, 2022 16:15
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #2723 (3cff04d) into master (458a60d) will decrease coverage by 0.00%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master    #2723      +/-   ##
==========================================
- Coverage   76.01%   76.01%   -0.01%     
==========================================
  Files         409      409              
  Lines       66856    66872      +16     
  Branches     2039     2037       -2     
==========================================
+ Hits        50820    50830      +10     
- Misses      15985    15991       +6     
  Partials       51       51              
Impacted Files Coverage Δ
...uro-app/src/scripts/dataset/files/file-display.jsx 49.00% <46.15%> (-0.44%) ⬇️
...src/scripts/dataset/routes/tab-routes-snapshot.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh merged commit 70a7c05 into master Nov 29, 2022
@nellh nellh deleted the display-file-snapshot-fix branch November 29, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants