Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show ORCID iDs for dataset uploaders #2737

Merged
merged 1 commit into from
Dec 15, 2022
Merged

feat: Show ORCID iDs for dataset uploaders #2737

merged 1 commit into from
Dec 15, 2022

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Dec 14, 2022

This is part one of ORCID updates to show a user's ORCID iD in several places. This includes the API changes and one of the frontend changes to demo it, displaying the id in the recommended minimal structure.

image

This supports the display half of this for Google auth users as well but does not include support for linking to your Google account yet.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #2737 (617123d) into master (d4eea34) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   76.05%   76.05%   -0.01%     
==========================================
  Files         410      411       +1     
  Lines       66948    66974      +26     
  Branches     2038     2041       +3     
==========================================
+ Hits        50916    50934      +18     
- Misses      15981    15989       +8     
  Partials       51       51              
Impacted Files Coverage Δ
...kages/openneuro-app/src/scripts/users/username.tsx 60.00% <60.00%> (ø)
...uro-app/src/scripts/dataset/snapshot-container.tsx 77.93% <100.00%> (+0.05%) ⬆️
...euro-app/src/scripts/search/use-search-results.tsx 35.67% <100.00%> (+0.18%) ⬆️
packages/openneuro-client/src/datasets.js 100.00% <100.00%> (ø)
packages/openneuro-server/src/graphql/schema.js 100.00% <100.00%> (ø)
packages/openneuro-server/src/models/user.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh merged commit 1ef4a13 into master Dec 15, 2022
@nellh nellh deleted the orcid-ids branch December 15, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants