Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Don't cache the default dataset_description response #2753

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jan 17, 2023

This prevents a bug where the inaccessible dataset_description.json response could be cached by moving it after cache resolution. This seems to be the main cause of #2707

A minor change here is to drop superagent for this request (uses native fetch instead).

This prevents a bug where the inaccessible dataset_description response could be cached by moving it after cache resolution
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #2753 (724f240) into master (c6f70fb) will decrease coverage by 0.01%.
The diff coverage is 52.17%.

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   76.04%   76.03%   -0.01%     
==========================================
  Files         411      411              
  Lines       66990    66993       +3     
  Branches     2039     2038       -1     
==========================================
- Hits        50942    50938       -4     
- Misses      15997    16004       +7     
  Partials       51       51              
Impacted Files Coverage Δ
...ckages/openneuro-server/src/datalad/description.js 74.32% <52.17%> (-4.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh merged commit 47b70cf into master Jan 18, 2023
@nellh nellh deleted the 2707-dataset-description-cache-fix branch January 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant