Automatically redirect when one is provided for a removed dataset #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 76.03% 76.01% -0.03%
==========================================
Files 412 412
Lines 66996 67023 +27
Branches 2042 2042
==========================================
+ Hits 50941 50946 +5
- Misses 16004 16026 +22
Partials 51 51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the UI for this was added as part of the redesign but the actual redirect step wasn't. This returns the redirect if it is a properly formatted URL pointing at another dataset, otherwise it is discarded. This will automatically redirect for most of the uses of this field so far, but we do have some DOI values that could be handled better.
Fixes #2765