Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing delete directory functionality #2778

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Fix missing delete directory functionality #2778

merged 6 commits into from
Mar 2, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 16, 2023

This component was implemented but failed to render in the appropriate context. Instead the bulk delete component was rendered multiple times instead of at the top level only.

This PR also fixes the cache logic so file deletion is handled client side correctly and removes some unused duplicate components left over from the redesign.

Fixes #2776

@nellh nellh requested a review from rwblair February 16, 2023 22:51
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #2778 (a0ae32d) into master (cbdf208) will decrease coverage by 0.18%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master    #2778      +/-   ##
==========================================
- Coverage   76.05%   75.88%   -0.18%     
==========================================
  Files         412      411       -1     
  Lines       67125    67157      +32     
  Branches     2046     2041       -5     
==========================================
- Hits        51052    50959      -93     
- Misses      16022    16147     +125     
  Partials       51       51              
Impacted Files Coverage Δ
...nneuro-app/src/scripts/dataset/files/file-tree.tsx 75.15% <20.00%> (-0.95%) ⬇️
...-app/src/scripts/dataset/mutations/delete-file.jsx 41.07% <29.78%> (-15.34%) ⬇️
...s/openneuro-app/src/scripts/dataset/files/file.tsx 69.52% <100.00%> (ø)
...penneuro-components/src/warn-button/WarnButton.tsx 18.94% <0.00%> (-76.85%) ⬇️
services/datalad/datalad_service/common/s3.py 83.78% <0.00%> (-2.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh merged commit ae52b46 into master Mar 2, 2023
@nellh nellh deleted the fix-delete-dir branch March 2, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Allow deleting directories on openneuro.org
2 participants