Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial schema validator frontend support #2779

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 17, 2023

This fixes some of the remaining issues with using the schema validator client side.

  • Allows site admins to configure which validator to use, defaulting the existing JS validator for regular users.
  • Displays the Issue content better so it's more useful for debugging.
  • Runs as its own worker.

This does not include the server side components, which is setting the option on the dataset to toggle which is used for display and running both validators on each change.

Also the entire schema validator is included here for testing this but ideally it would be an import from a CI build on the bids-validator repo. This is just the latest output of build.ts with one line added to have TypeScript ignore it as an external dependency.

@nellh nellh requested a review from rwblair February 17, 2023 17:58
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #2779 (1c0c165) into master (b42b1a7) will increase coverage by 0.26%.
The diff coverage is 58.62%.

❗ Current head 1c0c165 differs from pull request most recent head a16187e. Consider uploading reports for the commit a16187e to get more accurate results

@@            Coverage Diff             @@
##           master    #2779      +/-   ##
==========================================
+ Coverage   75.78%   76.05%   +0.26%     
==========================================
  Files         409      412       +3     
  Lines       67092    67133      +41     
  Branches     2035     2048      +13     
==========================================
+ Hits        50843    51055     +212     
+ Misses      16199    16027     -172     
- Partials       50       51       +1     
Impacted Files Coverage Δ
...c/scripts/validation/validation-results.issues.jsx 73.19% <55.55%> (-8.29%) ⬇️
...pts/validation/validation-results.issues.issue.jsx 85.55% <100.00%> (ø)
...-app/src/scripts/validation/validation-results.jsx 74.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh force-pushed the schema-validator-support branch from 1c0c165 to a16187e Compare April 27, 2023 17:42
@nellh nellh merged commit ccc5d37 into master Apr 27, 2023
@nellh nellh deleted the schema-validator-support branch April 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant