Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking ORCID to existing non-ORCID oauth accounts #2782

Merged
merged 6 commits into from
Mar 2, 2023

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Mar 1, 2023

Support linking your ORCID to any other primary accounts (Google). This doesn't merge these accounts but it does let enable ORCID features for your Google-authenticated account. Added a simple menu for this at the moment, it just lets you start the auth flow and will replace the ORCID account if you redo it with another account. You can only add this, not remove it, in this version.

@nellh nellh requested a review from rwblair March 1, 2023 19:33
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #2782 (88519ac) into master (2bee32a) will decrease coverage by 0.01%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
- Coverage   76.06%   76.05%   -0.01%     
==========================================
  Files         412      412              
  Lines       67117    67125       +8     
  Branches     2046     2046              
==========================================
+ Hits        51051    51052       +1     
- Misses      16015    16022       +7     
  Partials       51       51              
Impacted Files Coverage Δ
...ackages/openneuro-components/src/user/UserMenu.tsx 21.73% <0.00%> (-2.86%) ⬇️
...es/openneuro-server/src/libs/authentication/jwt.js 41.95% <100.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nellh nellh merged commit cbdf208 into master Mar 2, 2023
@nellh nellh deleted the link-orcid-google branch March 2, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants