fix(server): Set content-length and use faster fetch API for file transfers #2800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the superagent variant of getFile with the fetch equivalent. Testing locally with a 10GB nifti this is a little faster than the superagent version, which had been used for performance reasons originally.
This change also adds a content-length header to the response, allowing an HTTP client to detect errors when the connection is closed early.
This may fix #2798, I think this is worth trying in staging (it isn't reproducible locally).