fix(worker): Allow for remote.log existing without s3-PUBLIC in validation #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3064 +/- ##
=======================================
Coverage 42.21% 42.21%
=======================================
Files 601 601
Lines 38126 38127 +1
Branches 1113 1113
=======================================
+ Hits 16095 16097 +2
+ Misses 21815 21814 -1
Partials 216 216 ☔ View full report in Codecov by Sentry. |
…h instead of remote name
nellh
force-pushed
the
validate-s3-remote-failure
branch
from
9277dbf to
a62793d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit validation to OpenNeuro's created remote.log entries, instead of failing if only externally created remotes exist.