Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(draft-render): Display editable list elements inline #3080

Merged

Conversation

effigies
Copy link
Contributor

Change display from inline-block, which respects top/bottom margin/padding, to inline, which doesn't.

Before

Screenshot from 2024-06-14 12-47-27

After

Screenshot from 2024-06-14 12-47-18

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.44%. Comparing base (9eab62f) to head (430608a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   42.36%   43.44%   +1.08%     
==========================================
  Files         595      595              
  Lines       37919    37919              
  Branches     1096     1130      +34     
==========================================
+ Hits        16064    16475     +411     
+ Misses      21643    21245     -398     
+ Partials      212      199      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 49c4bce into OpenNeuroOrg:master Jun 15, 2024
10 of 11 checks passed
@effigies effigies deleted the fix/display-list-elements-inline branch June 16, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants