Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): Support gzip for git clients that require it #3103

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jul 16, 2024

This is a fallback mode for when the client has set "content-encoding: gzip". Without this, we pass the gzipped response to git-upload-pack/git-receive-pack and this will crash with a protocol error, closing the connection.

Ideally HTTP decompression is handled before the Falcon request handler but introducing an HTTP proxy here is a larger change.

See #3087

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.63%. Comparing base (df9d423) to head (b60a724).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3103   +/-   ##
=======================================
  Coverage   42.62%   42.63%           
=======================================
  Files         592      592           
  Lines       37857    37860    +3     
  Branches     1098     1098           
=======================================
+ Hits        16137    16140    +3     
  Misses      21513    21513           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 45b92c3 into master Jul 16, 2024
10 of 11 checks passed
@nellh nellh deleted the support-gzip branch July 16, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant