Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(worker): Update to pygit2 0.15.1 #3113

Merged
merged 2 commits into from
Aug 7, 2024
Merged

deps(worker): Update to pygit2 0.15.1 #3113

merged 2 commits into from
Aug 7, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 7, 2024

Resolves breaking changes from pygit2 0.14 -> 0.15.

https://github.com/libgit2/pygit2/blob/master/CHANGELOG.md#1150-2024-05-18

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.63%. Comparing base (80963c5) to head (b638dc7).

Files Patch % Lines
...rvices/datalad/datalad_service/handlers/history.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3113   +/-   ##
=======================================
  Coverage   42.63%   42.63%           
=======================================
  Files         594      594           
  Lines       37874    37874           
  Branches     1098     1098           
=======================================
  Hits        16149    16149           
  Misses      21518    21518           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a deeply obnoxious refactor, as literally every object can be str()'d. I started looking into it a while back and backed off when I realized it wasn't all X.hex -> str(X). So hats off to you.

There's one line missing coverage. Are you confident in that one?

@nellh
Copy link
Contributor Author

nellh commented Aug 7, 2024

There's one line missing coverage. Are you confident in that one?

Added a new test to check for the expected tag reference to cover that change.

@nellh nellh merged commit 155ca98 into master Aug 7, 2024
6 of 9 checks passed
@nellh nellh deleted the pygit-0.15-update branch August 7, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants