Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker fixes for deletion #3130

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Worker fixes for deletion #3130

merged 2 commits into from
Aug 28, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Aug 27, 2024

Fixes #3128. Runs S3 file cleanup in a process but otherwise waits for deletion to be finished before returning success.

Couple minor fixes included:

  • Fixes the redirect after deletion to correctly return to search.
  • Avoids eating errors in during deletion and logs them now.
  • 404 if the request is made on a dataset which as already been deleted but not otherwise.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 43.10%. Comparing base (b33cd43) to head (021b19d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...rvices/datalad/datalad_service/handlers/dataset.py 50.00% 3 Missing ⚠️
services/datalad/datalad_service/tasks/publish.py 57.14% 3 Missing ⚠️
...neuro-app/src/scripts/datalad/mutations/delete.jsx 0.00% 1 Missing ⚠️
...neuro-app/src/scripts/dataset/mutations/delete.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3130      +/-   ##
==========================================
+ Coverage   43.08%   43.10%   +0.02%     
==========================================
  Files         596      596              
  Lines       37849    37840       -9     
  Branches     1095     1095              
==========================================
+ Hits        16307    16311       +4     
+ Misses      21335    21322      -13     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 185a08b into master Aug 28, 2024
8 of 10 checks passed
@nellh nellh deleted the 3128-delete-fixes branch August 28, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset deletion failing
1 participant