Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Decouple React client from @openneuro/client #3194

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Nov 7, 2024

The client package will no longer be needed with the move to deno CLI and this allows for frontend specific client configuration.

Fixes error handling not bubbling up properly across the React app. Otherwise no functional changes.

@nellh nellh force-pushed the app-decouple-client branch from 9e65900 to aea148c Compare November 7, 2024 19:53
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 14.85507% with 235 lines in your changes missing coverage. Please review.

Project coverage is 44.26%. Comparing base (0d7bdd7) to head (9cd288d).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...o-app/src/scripts/uploader/file-upload-parallel.ts 0.00% 121 Missing and 1 partial ⚠️
...enneuro-app/src/scripts/uploader/hash-file-list.ts 0.00% 35 Missing and 1 partial ⚠️
...nneuro-app/src/scripts/uploader/upload-mutation.js 0.00% 31 Missing and 1 partial ⚠️
...es/openneuro-app/src/scripts/uploader/uploader.jsx 0.00% 24 Missing ⚠️
packages/openneuro-app/src/client.jsx 0.00% 15 Missing ⚠️
.../openneuro-app/src/scripts/uploader/file-upload.js 0.00% 3 Missing ⚠️
...app/src/scripts/dataset/download/download-query.js 94.44% 2 Missing ⚠️
...ackages/openneuro-app/src/scripts/utils/datalad.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3194      +/-   ##
==========================================
- Coverage   44.45%   44.26%   -0.19%     
==========================================
  Files         592      594       +2     
  Lines       37861    38104     +243     
  Branches     1131     1133       +2     
==========================================
+ Hits        16830    16868      +38     
- Misses      20831    21034     +203     
- Partials      200      202       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The client will no longer be needed with the move to deno CLI and this allows for frontend specific client configuration.

Fixes error handling not bubbling up properly across the React app.
@nellh nellh force-pushed the app-decouple-client branch from aea148c to 9cd288d Compare November 7, 2024 20:13
@nellh nellh merged commit defc554 into master Nov 11, 2024
13 of 15 checks passed
@nellh nellh deleted the app-decouple-client branch November 11, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant