-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to JSR schema validator #3206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "module": "esnext" and "moduleResolution": "bundler" to allow the integration to load
0ec915f
to
5caacee
Compare
02e3c68
to
258a56c
Compare
Vite's asset import glob plugin will mangle this import and we don't need the import meta info in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the legacy BIDS validator, switching to only the schema validator for new validation runs. The schema validator is now the default for all datasets.
The schema validator output is now in a new database model, this is the only new validation runs that will be created after this is deployed.
Existing validation data is still available on the draft.issues and snapshot.issues fields as before. You can get both like this:
For schema validation this also adds a sort for location or code:
Also requires #3003 to be merged.