Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user schema to include new fields and ability to updateUser #3272

Merged
merged 16 commits into from
Jan 14, 2025

Conversation

thinknoack
Copy link
Contributor

@thinknoack thinknoack commented Jan 9, 2025

This contains the editing feature for user content on the about page. It also adds the hasEdit, loggedIn, and admin checks.

@thinknoack thinknoack self-assigned this Jan 9, 2025
@thinknoack thinknoack marked this pull request as draft January 9, 2025 18:59
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 74.18182% with 71 lines in your changes missing coverage. Please review.

Project coverage is 47.01%. Comparing base (ec2c84b) to head (a4ef889).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
...ges/openneuro-server/src/graphql/resolvers/user.ts 13.88% 31 Missing ⚠️
packages/openneuro-app/src/scripts/routes.tsx 0.00% 16 Missing ⚠️
...o-app/src/scripts/users/components/edit-string.tsx 82.00% 9 Missing ⚠️
packages/openneuro-server/src/graphql/schema.ts 0.00% 6 Missing ⚠️
...uro-app/src/scripts/users/components/edit-list.tsx 81.48% 5 Missing ⚠️
.../src/scripts/users/components/editable-content.tsx 93.33% 2 Missing ⚠️
...openneuro-server/src/graphql/resolvers/mutation.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
+ Coverage   46.67%   47.01%   +0.33%     
==========================================
  Files         609      609              
  Lines       38739    38971     +232     
  Branches     1232     1253      +21     
==========================================
+ Hits        18083    18321     +238     
+ Misses      20461    20455       -6     
  Partials      195      195              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinknoack thinknoack requested a review from nellh January 10, 2025 00:14
@thinknoack thinknoack changed the title update user schema to include new fields update user schema to include new fields and ability to updateUser Jan 10, 2025
Copy link
Contributor

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with several kinds of users and it looks like it's in a pretty good state.

@thinknoack thinknoack marked this pull request as ready for review January 14, 2025 18:20
@nellh nellh merged commit 794f576 into master Jan 14, 2025
15 checks passed
@nellh nellh deleted the userSchema branch January 14, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants