Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Show download finished message only after it has completely run #3281

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jan 15, 2025

For smaller datasets this would be pretty synchronous but the worker can be transferring objects for a while. Wait for the worker to send the closed message before showing the download complete message.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (794f576) to head (75ec5e1).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
cli/src/commands/download.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   46.85%   46.84%   -0.01%     
==========================================
  Files         610      610              
  Lines       39102    39115      +13     
  Branches     1254     1255       +1     
==========================================
+ Hits        18321    18325       +4     
- Misses      20585    20594       +9     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 56d4736 into master Jan 15, 2025
13 of 15 checks passed
@nellh nellh deleted the cli/download-finished branch January 15, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant