Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Fix path-browserify throwing syntax error #3291

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jan 17, 2025

This is a regression introduced by [email protected].

Pinning to the older version until this can be fixed upstream. Previously isomorphic-git would use an internal implementation of path.join but broke deno support by migrating to path-browserify.

Fixes #3289

This is a regression introduced by [email protected].

Pinning to the older version until this can be fixed upstream.
@nellh nellh requested a review from thinknoack January 17, 2025 20:40
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.81%. Comparing base (977d5a1) to head (9f1b36a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3291   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files         610      610           
  Lines       39145    39145           
  Branches     1255     1255           
=======================================
  Hits        18325    18325           
  Misses      20624    20624           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinknoack
Copy link
Contributor

running the upload locally with this branch works

? Create a new dataset? (y/n) › Yes
Detected 49 changes.
Transferring annexed files 100.00%                                                    0.1s 12/12 
Pushing changes...
Upload complete, visit your dataset at http://localhost:9876/datasets/ds001010
nonopersonal@PSY-KFV271XNTL 12:48:33 ~/Sites/openneuro fix/3289-path-browserify $ 

Copy link
Contributor

@thinknoack thinknoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me on mac

@nellh nellh merged commit db74a96 into master Jan 17, 2025
15 checks passed
@nellh nellh deleted the fix/3289-path-browserify branch January 17, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors when upload using the newest CLI
2 participants