Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Be consistent about using deno.json's import map #3295

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Jan 21, 2025

In a few places the CLI was not using the import map correctly.

See #3289.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.02%. Comparing base (2964fad) to head (5807e73).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cli/src/worker/annex.ts 0.00% 2 Missing ⚠️
cli/src/gitattributes.ts 0.00% 0 Missing and 1 partial ⚠️
cli/src/worker/git.ts 0.00% 1 Missing ⚠️
cli/src/worker/types/git-context.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3295   +/-   ##
=======================================
  Coverage   47.02%   47.02%           
=======================================
  Files         583      583           
  Lines       36945    36945           
  Branches     1174     1174           
=======================================
  Hits        17372    17372           
  Misses      19386    19386           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 3df9968 into master Jan 21, 2025
14 of 15 checks passed
@nellh nellh deleted the cli/isomorphic-git-versions branch January 21, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant