Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init layouts and styles for user notifications view #3298

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

thinknoack
Copy link
Contributor

@thinknoack thinknoack commented Jan 24, 2025

this provides the default styling and layouts for notifications with some dummydata. I think it is good to review and I will write tests once the data is correct. Let me know if that works.

@thinknoack thinknoack marked this pull request as draft January 24, 2025 19:55
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 77.20207% with 88 lines in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (1c61144) to head (a63c7c7).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
.../src/scripts/users/user-notification-accordion.tsx 68.75% 50 Missing ⚠️
...-app/src/scripts/users/user-notifications-view.tsx 82.17% 18 Missing ⚠️
...c/scripts/users/user-notifications-tab-content.tsx 83.52% 14 Missing ⚠️
...o-app/src/scripts/users/user-notification-list.tsx 77.77% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3298      +/-   ##
==========================================
+ Coverage   47.42%   47.72%   +0.29%     
==========================================
  Files         587      590       +3     
  Lines       37285    37666     +381     
  Branches     1243     1272      +29     
==========================================
+ Hits        17683    17976     +293     
- Misses      19415    19503      +88     
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinknoack thinknoack requested a review from nellh January 28, 2025 19:14
@thinknoack thinknoack marked this pull request as ready for review January 28, 2025 19:14
@nellh nellh merged commit 860888a into master Feb 4, 2025
15 checks passed
@nellh nellh deleted the user-notifications-layouts branch February 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants