Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brain Initiative Landing Page #3314

Merged
merged 12 commits into from
Feb 12, 2025
Merged

Brain Initiative Landing Page #3314

merged 12 commits into from
Feb 12, 2025

Conversation

thinknoack
Copy link
Contributor

@thinknoack thinknoack commented Jan 30, 2025

adds to the search ctx and params to search for datasets where brain_initiative == "true".

also contains the various styling and components to accommodate the new NIH Brain Initiative portal.

@thinknoack thinknoack requested a review from nellh January 30, 2025 23:22
@thinknoack thinknoack marked this pull request as draft January 30, 2025 23:22
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 61.50442% with 87 lines in your changes missing coverage. Please review.

Project coverage is 47.32%. Comparing base (cff1be3) to head (e63cdc5).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...euro-components/src/search-page/ModalityHeader.tsx 2.94% 33 Missing ⚠️
...nneuro-app/src/scripts/search/search-container.tsx 15.00% 17 Missing ⚠️
...openneuro-app/src/scripts/search/search-routes.tsx 0.00% 14 Missing ⚠️
...euro-app/src/scripts/search/use-search-results.tsx 0.00% 11 Missing ⚠️
...neuro-app/src/scripts/search/inputs/nih-select.tsx 85.71% 9 Missing ⚠️
...neuro-app/src/scripts/search/search-params-ctx.tsx 0.00% 2 Missing ⚠️
...penneuro-components/src/search-page/SearchPage.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage   47.20%   47.32%   +0.12%     
==========================================
  Files         592      595       +3     
  Lines       37843    38033     +190     
  Branches     1247     1261      +14     
==========================================
+ Hits        17864    18000     +136     
- Misses      19792    19846      +54     
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinknoack thinknoack changed the title [WIP] init for brain hack needs work [WIP] Brain Initiative Landing Page Feb 5, 2025
@thinknoack thinknoack changed the title [WIP] Brain Initiative Landing Page Brain Initiative Landing Page Feb 10, 2025
@thinknoack thinknoack marked this pull request as ready for review February 10, 2025 21:50
Copy link
Contributor

@nellh nellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and made one small change to how the value was being queried but this looks ready to go.

@nellh nellh merged commit 4048ed5 into master Feb 12, 2025
15 checks passed
@nellh nellh deleted the nih-modality branch February 12, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants