Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Require events.tsv for non-rest tasks #3318

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Feb 1, 2025

Promotes EVENTS_TSV_MISSING to an error.

This may end up with some false positives. We should be able to do some additional filtering based on path, but if the logic gets complicated then this would be a good use case for patching the schema.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.33%. Comparing base (8606dc5) to head (a9afbee).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3318   +/-   ##
=======================================
  Coverage   47.33%   47.33%           
=======================================
  Files         595      595           
  Lines       38031    38031           
  Branches     1261     1261           
=======================================
  Hits        18001    18001           
  Misses      19843    19843           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh force-pushed the feat/require-events-tsv branch from 51c64e5 to a9afbee Compare February 12, 2025 23:50
@nellh nellh merged commit f98d87e into master Feb 12, 2025
13 checks passed
@nellh nellh deleted the feat/require-events-tsv branch February 12, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants