Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Demote PARTICIPANT_ID_MISMATCH to a warning for now #3320

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Feb 4, 2025

Addressing problems with https://openneuro.org/datasets/ds005752/ that can't be reasonably resolved within the dataset. This is quite a minor issue, and we can hopefully get rid of this exception soon.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.15%. Comparing base (b5d94f0) to head (8477fd0).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
...openneuro-app/src/scripts/workers/schema.worker.ts 0.00% 2 Missing ⚠️
cli/src/commands/upload.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3320      +/-   ##
==========================================
+ Coverage   47.21%   48.15%   +0.93%     
==========================================
  Files         591      595       +4     
  Lines       37768    38031     +263     
  Branches     1243     1295      +52     
==========================================
+ Hits        17834    18315     +481     
+ Misses      19747    19538     -209     
+ Partials      187      178       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the feat/warn-participant-id-mismatch branch from 5fcc2dc to 2be2eda Compare February 11, 2025 17:02
@effigies
Copy link
Contributor Author

@nellh Not sure if 2be2eda is what you had in mind...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could symlink this one too, then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get that to work but gave up on it. I've also had to go back to using a non-symlinked one for the JSR CLI, so there's just going to be several copies.

@nellh nellh merged commit 8606dc5 into OpenNeuroOrg:master Feb 12, 2025
15 checks passed
@effigies effigies deleted the feat/warn-participant-id-mismatch branch February 13, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants