Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add private dataset alert to snapshots for dataset admins #3332

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

effigies
Copy link
Contributor

This attempts to be DRY by pulling out the warning that is shown on the draft when a dataset has snapshots and is private into a DatasetAlertPrivate component. This is then added to the snapshot page if the dataset is private and the user is an admin.

Closes #3331.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.16%. Comparing base (4048ed5) to head (ed34c4c).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...uro-app/src/scripts/dataset/snapshot-container.tsx 60.00% 4 Missing ⚠️
...nneuro-app/src/scripts/dataset/draft-container.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   47.32%   48.16%   +0.84%     
==========================================
  Files         595      595              
  Lines       38033    38055      +22     
  Branches     1261     1298      +37     
==========================================
+ Hits        18000    18331     +331     
+ Misses      19846    19546     -300     
+ Partials      187      178       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the feat/private-dataset-snapshots branch 3 times, most recently from a6f4ca5 to 6c99ec8 Compare February 12, 2025 19:07
@effigies effigies force-pushed the feat/private-dataset-snapshots branch from 6c99ec8 to ed34c4c Compare February 12, 2025 19:11
@nellh nellh merged commit 96574b6 into OpenNeuroOrg:master Feb 13, 2025
15 checks passed
@effigies effigies deleted the feat/private-dataset-snapshots branch February 13, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "This dataset has not been published" banner on snapshots for dataset admins
2 participants