Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDAL vector templates: Coordinate system choice "Map" not saved #1768

Open
dg0yt opened this issue Nov 2, 2020 · 0 comments
Open

GDAL vector templates: Coordinate system choice "Map" not saved #1768

dg0yt opened this issue Nov 2, 2020 · 0 comments
Assignees

Comments

@dg0yt
Copy link
Member

dg0yt commented Nov 2, 2020

Steps to reproduce

  1. Add a DXF or SVG template with "Coordinate System" choice "Map".
  2. Mark significant template points in the map.
  3. Save, close, open again.

Actual behaviour

The template appears with different scale and position. The marked points do no longer match the template.
(However, the parameters in the template positioning dialog are unchanged.)

Expected behaviour

The template must appear with the original scale and position.

Configuration

Mapper Version: v0.9.4

Remark

During template setup, the coordinate system choice is set in member variable OgrTemplate::selcted_unit which affects template data loading. This variable is neither saved to, or loaded from, map files.
DXF format was initially supported via TemplateTrack. Ideally, OgrTemplate should continue be able to correctly load legacy map files with DXF templates in both map CS and projected CS.

@dg0yt dg0yt self-assigned this Nov 2, 2020
dg0yt added a commit that referenced this issue Nov 29, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This is a behavioural change, but it is hidden by the fact that Mapper
failed to save the CS choice "Map" (GH-1768).
dg0yt added a commit that referenced this issue Nov 29, 2020
This is a behavioural change, but it is hidden by the fact that
Mapper fails to save the CS choice "Map" (GH-1768).
dg0yt added a commit that referenced this issue Dec 1, 2020
Fixes GH-1768 (Coordinate system choice 'map' not saved).
dg0yt added a commit that referenced this issue Jan 5, 2021
This is a behavioural change, but it is hidden by the fact that
Mapper fails to save the CS choice "Map" (GH-1768).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant