Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for formatted string in convertors #3804

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

DimitarCC
Copy link
Contributor

This is because of remarks of @Taapat ....

Now you can define in the skin with whatever case you want and that will work.
Also spaces can be configured in the skin as well now.

@littlesat
Copy link
Member

Why not force the complete thing to upper instead do it label by label

@littlesat littlesat merged commit 6cf455f into OpenPLi:develop Oct 18, 2023
@DimitarCC
Copy link
Contributor Author

I cant force it to upper because of the separator string and normal types that was used before. If i force type to be uppercase the normal
<convert type="ServiceName">Reference</convert>
not going to work anymore.

@DimitarCC
Copy link
Contributor Author

P.S. i was thinking for even more flexible way to define that string format....
I will prepare another pull for discussion....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants