cfCatalogLoad: fix incorrect strncpy() limit calculation #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve the new allocated size in a variable and use it instead of sizeof(). The old calculation would wrap around in most cases, making the limit ineffective. For very short original length of `human_readable` (6 bytes or less on 64-bit platforms), the appended text would be cut short to fit the pointer size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the new allocated size in a variable and use it instead of sizeof().
The old calculation would wrap around in most cases, making the limit ineffective. For very short original length of
human_readable(6 bytes or less on 64-bit platforms), the appended text would be cut short to fit the pointer size.