Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #516

Closed
wants to merge 36 commits into from
Closed

Spelling #516

wants to merge 36 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 15, 2022

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@be59c73#commitcomment-71364823

The action reports that the changes in this PR would make it happy: jsoref@f0cdc94

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

init.sh: rework the /run setup for linux xystems
init.sh: rework the /run setup for linux systems
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

conf.d/keymaps Outdated Show resolved Hide resolved
conf.d/keymaps Outdated
Comment on lines 8 to 9
# using the special windows keys on the linux console.
windowkeys="NO"
windowskeys="NO"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It kinda feels like they mean this.

init.d/keymaps.in Outdated Show resolved Hide resolved
by s6 then runs rc-status to show info about nnormal OpenRC services.
by s6 then runs rc-status to show info about normal OpenRC services.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes random letters are intentional, but I don't think that's the case here.

exists to quickly add or delete services to and from from different runlevels.
exists to quickly add or delete services to and from different runlevels.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell checkers have been flagging duplicate words for many decades, but I've only recently started to work with them. It's possible I've messed up in places, but I don't thinks so.

@williamh
Copy link
Contributor

Please rebase this on master. Also:

  • it should be windowkeys, not windowskeys, so drop that change (see /usr/share/keymaps/*)
  • You don't need the signed-off-by lines in OpenRC, so feel free to not use them.

@jsoref
Copy link
Contributor Author

jsoref commented Apr 26, 2022

I'm not at all attached to the signed-off-by lines, they're there because I regularly run into automation that screams at me when I don't have it. Quite happy to drop.

re: window-keys, what about this: #516 (comment) -- is $SET_WINDOWSKEYS correct? Should it be $SET_WINDOWKEYS?

@williamh
Copy link
Contributor

I would leave that the way it is on master for now.

Thanks,

William

@williamh
Copy link
Contributor

The ChangeLog is auto generated so changes to it will be overwritten. I'm also thinking about removing that file in the future since I don't have a way to autogenerate it with the new build system. I will squash and merge all commits except that one.
Thanks much for doing this and for keeping all of your commits small so I could review them easily.

@williamh williamh closed this in 3054046 May 1, 2022
@jsoref jsoref deleted the spelling branch May 1, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants