Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can save checkpoints with callbacks #114

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Conversation

huangshiyu13
Copy link
Member

@huangshiyu13 huangshiyu13 commented Jun 20, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make commit-checks (required).

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #114 (fe4ed26) into main (4c51fcd) will increase coverage by 0.01%.
The diff coverage is 45.24%.

❗ Current head fe4ed26 differs from pull request most recent head f6cd283. Consider uploading reports for the commit f6cd283 to get more accurate results

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   45.31%   45.33%   +0.01%     
==========================================
  Files         147      153       +6     
  Lines        9233     9690     +457     
==========================================
+ Hits         4184     4393     +209     
- Misses       5049     5297     +248     
Flag Coverage Δ
unittests 45.33% <45.24%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/drivers/offpolicy_driver.py 23.94% <0.00%> (+4.17%) ⬆️
openrl/modules/networks/utils/nlp/base_policy.py 0.00% <ø> (ø)
openrl/runners/common/dqn_agent.py 56.66% <ø> (ø)
openrl/runners/common/vdn_agent.py 56.66% <ø> (ø)
openrl/utils/evaluation.py 13.79% <13.79%> (ø)
openrl/utils/callbacks/checkpoint_callback.py 29.62% <29.62%> (ø)
openrl/utils/callbacks/callbacks.py 39.22% <39.22%> (ø)
openrl/envs/vec_env/__init__.py 61.11% <50.00%> (-38.89%) ⬇️
openrl/utils/callbacks/callbacks_factory.py 56.25% <56.25%> (ø)
openrl/drivers/onpolicy_driver.py 94.04% <81.25%> (-1.85%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant