fixup! front: add speed space chart e2e test

OpenRailAssociation · Dec 13, 2024 · ac4f85a · ac4f85a
1 parent aee825c
commit ac4f85a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 20 deletions.
diff --git a/front/tests/012-op-simulation-settings-tab.spec.ts b/front/tests/012-op-simulation-settings-tab.spec.ts
@@ -173,8 +173,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.returnSimulationResult();
     await opTimetablePage.getTrainArrivalTime('11:53');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(
@@ -199,8 +197,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await page.waitForTimeout(stabilityTimeout); // Waiting for the timetable to update due to a slight latency
     await opTimetablePage.getTrainArrivalTime('11:52');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(
@@ -257,8 +253,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.returnSimulationResult();
     await opTimetablePage.getTrainArrivalTime('12:03');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(
@@ -283,8 +277,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await page.waitForTimeout(stabilityTimeout);
     await opTimetablePage.getTrainArrivalTime('11:52');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(
@@ -350,8 +342,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.returnSimulationResult();
     await opTimetablePage.getTrainArrivalTime('11:54');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(
@@ -376,8 +366,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await page.waitForTimeout(stabilityTimeout);
     await opTimetablePage.getTrainArrivalTime('11:54');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(
@@ -444,8 +432,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.returnSimulationResult();
     await opTimetablePage.getTrainArrivalTime('12:06');
     await opTimetablePage.clickOnScenarioCollapseButton();
-    // TODO: Remove the waitForTimeout and firefox from performOnSpecificOSAndBrowser when issue #9909 is fixed
-    await page.waitForTimeout(stabilityTimeout);
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
     await simulationResultPage.selectAllSpeedSpaceChartCheckboxes();
     await performOnSpecificOSAndBrowser(

diff --git a/front/tests/pages/common-page-model.ts b/front/tests/pages/common-page-model.ts
@@ -43,12 +43,8 @@ class CommonPage {
   }
 
   async closeToastNotification(): Promise<void> {
-    const toastCount = await this.toastSNCF.count();
-
-    if (toastCount > 0) {
-      const toastElements = await this.toastSNCF.all();
-      await Promise.all(toastElements.map((toastElement) => toastElement.click()));
-    }
+    const toastElements = await this.toastSNCF.all();
+    await Promise.all(toastElements.map((toastElement) => toastElement.click()));
   }
 }