Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No limit in tag lengths for project, studies, and scenarios #5715

Closed
axrolld opened this issue Nov 16, 2023 · 2 comments · Fixed by #5901
Closed

No limit in tag lengths for project, studies, and scenarios #5715

axrolld opened this issue Nov 16, 2023 · 2 comments · Fixed by #5901
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:minor Minor severity bug

Comments

@axrolld
Copy link
Contributor

axrolld commented Nov 16, 2023

What happened?

This is a very minor bug because it only happens if the user is pretty extreme. There is no urge to fix that.

But, here's what's happening :

1.mp4

image

What did you expect to happen?

There should be a limit in length for each idividual tag (proposal : 30 max), and the card should only show one line of tags, followed by ...

How can we reproduce it (as minimally and precisely as possible)?

  1. Create a project, study, or scenario with a lot of creativity for tag names

What operating system, browser and environment are you using?

dev

OSRD version (top right corner Account button > Informations)

c482536

@axrolld axrolld added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:minor Minor severity bug module:operational-studies Multi-train simulation with structured studies management labels Nov 16, 2023
@Yohh Yohh self-assigned this Nov 28, 2023
@nicolaswurtz
Copy link
Contributor

nicolaswurtz commented Nov 29, 2023

I propose to not limit input field to 30 chars, but limit display to 30 chars with ellipsis. I prefer not to coerce user, but restrain display capabilities instead. What do you think ?

If we limit input field, we would have to inform user of this restriction somewhere...

@axrolld
Copy link
Contributor Author

axrolld commented Nov 29, 2023

I don't think that limiting the length of a tag field is really constraining for the user, but limiting the display also works, i just thought it was more complicated.

I'm ok with both solutions !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:minor Minor severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants