Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: oprationnalstudies: adds label maxlength, maxwidth and elipsis #5901

Merged
merged 1 commit into from
Nov 29, 2023
Merged

front: oprationnalstudies: adds label maxlength, maxwidth and elipsis #5901

merged 1 commit into from
Nov 29, 2023

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Nov 28, 2023

close #5715

@Yohh Yohh added area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management labels Nov 28, 2023
@Yohh Yohh requested a review from a team as a code owner November 28, 2023 21:23
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31f40a6) 19.69% compared to head (dfeda45) 19.68%.
Report is 3 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5901      +/-   ##
============================================
- Coverage     19.69%   19.68%   -0.01%     
  Complexity     2122     2122              
============================================
  Files           910      910              
  Lines        108529   108544      +15     
  Branches       2659     2659              
============================================
  Hits          21372    21372              
- Misses        85593    85608      +15     
  Partials       1564     1564
Flag Coverage Δ
front 8.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohh Yohh force-pushed the yoh/front-add-labels-maxlength-and-elipsis-for-operationnal-studies-cards branch from 259f22d to dfeda45 Compare November 29, 2023 09:54
@Yohh Yohh added this pull request to the merge queue Nov 29, 2023
Merged via the queue into dev with commit 3049eca Nov 29, 2023
6 of 7 checks passed
@Yohh Yohh deleted the yoh/front-add-labels-maxlength-and-elipsis-for-operationnal-studies-cards branch November 29, 2023 10:25
Akctarus
Akctarus reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akctarus Akctarus Akctarus left review comments

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No limit in tag lengths for project, studies, and scenarios
3 participants
@Yohh @nicolaswurtz @Akctarus