Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use the absolute value in useOutputData for lateness #10094

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 16, 2024

closes #8951

Use the absolute value of the duration between 2 dates to determine whether a train is late or not (this duration should be inferior to 1s).

Use the absolute value of the duration between 2 dates to determine whether
a train is late or not (this duration should be inferior to 1s).

Signed-off-by: Clara Ni <[email protected]>
@clarani clarani requested a review from a team as a code owner December 16, 2024 16:52
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (70e728e) to head (b3de41e).
Report is 13 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10094      +/-   ##
==========================================
- Coverage   79.81%   79.80%   -0.01%     
==========================================
  Files        1052     1052              
  Lines      105439   105440       +1     
  Branches      727      727              
==========================================
- Hits        84152    84145       -7     
- Misses      21245    21253       +8     
  Partials       42       42              
Flag Coverage Δ
editoast 73.72% <ø> (-0.03%) ⬇️
front 89.12% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani enabled auto-merge December 17, 2024 10:49
@clarani clarani added this pull request to the merge queue Dec 17, 2024
Merged via the queue into dev with commit d69d60f Dec 17, 2024
27 checks passed
@clarani clarani deleted the cni/8951-schedule-points-not-honored-in-tolerance branch December 17, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule points marked as not honored even though they're within tolerance
3 participants