Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: add comment to clarify earliest conflict operation #10153

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Dec 20, 2024

Follow up of #10126 after @bougue-pe's input.

The logic doesn't change, we just add a clarifying comment.

@eckter eckter requested a review from bougue-pe December 20, 2024 10:56
@eckter eckter requested a review from a team as a code owner December 20, 2024 10:56
@eckter eckter requested a review from Khoyo December 20, 2024 10:56
@github-actions github-actions bot added the area:core Work on Core Service label Dec 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (7582bdd) to head (eb47878).
Report is 378 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10153      +/-   ##
==========================================
- Coverage   79.95%   79.93%   -0.02%     
==========================================
  Files        1057     1057              
  Lines      106403   106403              
  Branches      726      726              
==========================================
- Hits        85077    85058      -19     
- Misses      21284    21303      +19     
  Partials       42       42              
Flag Coverage Δ
editoast 73.91% <ø> (-0.07%) ⬇️
front 89.20% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bougue-pe bougue-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks !

@eckter eckter requested review from Erashin and removed request for Khoyo February 4, 2025 14:41
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trusting you on this ^^"

@eckter eckter added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit 518a61f Feb 4, 2025
27 checks passed
@eckter eckter deleted the ech/comment-last-pr branch February 4, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants