Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: create itinerary reducer #10205

Merged
merged 2 commits into from
Jan 28, 2025
Merged

front: create itinerary reducer #10205

merged 2 commits into from
Jan 28, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 30, 2024 •
edited
Loading

To merge after #10194

@clarani clarani self-assigned this Dec 30, 2024
@clarani clarani mentioned this pull request Jan 2, 2025
Merged
@clarani clarani force-pushed the cni/create-itinerary-reducer branch from 710add3 to 2963fe0 Compare January 3, 2025 11:36
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (c4c4c58) to head (d865b89).
Report is 73 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (c4c4c58) and HEAD (d865b89). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (c4c4c58) HEAD (d865b89)
railjson_generator 2 1
gateway 2 1
osrdyne 2 1
tests 2 1
front 2 0
editoast 2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##              dev   #10205       +/-   ##
===========================================
- Coverage   81.79%   68.01%   -13.78%     
===========================================
  Files        1073      371      -702     
  Lines      106543    37818    -68725     
  Branches      727        0      -727     
===========================================
- Hits        87147    25723    -61424     
+ Misses      19357    12095     -7262     
+ Partials       39        0       -39
Flag Coverage Δ
editoast 74.19% <ø> (-0.02%) ⬇️
front ?
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani force-pushed the cni/create-itinerary-reducer branch from 2963fe0 to 160aedf Compare January 3, 2025 12:00
@clarani clarani marked this pull request as ready for review January 3, 2025 13:10
@clarani clarani requested a review from a team as a code owner January 3, 2025 13:10
@clarani clarani requested review from Yohh and SharglutDev January 3, 2025 13:10
Yohh
Yohh approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm 💪

@clarani clarani force-pushed the cni/create-itinerary-reducer branch from 14be3eb to 0740c36 Compare January 9, 2025 14:34
SharglutDev
SharglutDev approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! Just one question

front/src/reducers/osrdconf/operationalStudiesConf/itineraryReducer.ts Show resolved Hide resolved
clarani and others added 2 commits January 20, 2025 14:12
@clarani clarani force-pushed the cni/create-itinerary-reducer branch from 0740c36 to d865b89 Compare January 20, 2025 13:12
@SharglutDev
Copy link
Contributor

This should maybe wait the end of the PI freeze to be merged ? Or refacto accepted ?

@clarani
Copy link
Contributor Author

clarani commented Jan 27, 2025

I think this should wait at least the I&A tomorrow :)

@clarani clarani added this pull request to the merge queue Jan 28, 2025
Merged via the queue into dev with commit 892a5a6 Jan 28, 2025
27 checks passed
@clarani clarani deleted the cni/create-itinerary-reducer branch January 28, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees

@clarani clarani

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clarani @codecov-commenter @SharglutDev @Yohh